ramu11 commented on PR #28354:
URL: https://github.com/apache/camel/pull/28354#issuecomment-6381733399
Thanks @Croway . The bounded session-retention changes are implemented
in our `SpringAiToolSearch` / `AiToolSearchSessions` code, with capacity
limits, idle expiry, lazy registration, and explicit invalidation.
I have two lifecycle questions before completing the remaining integration:
1. **Producer shutdown:** Since `SpringAiChatProducer` is maintained in your
code, can we agree on a lifecycle hook for it to invoke a cleanup method
exposed by our `SpringAiToolSearch` implementation? That cleanup would clear
retained sessions and cached tool-index references owned by the search instance.
2. **Chat-memory eviction:** Should we support invalidation only for
explicit conversation clears, or is automatic invalidation on memory eviction
required? The code shared so far exposes no general eviction callback. If
automatic invalidation is required, which `ChatMemory` implementation and
lifecycle hook should we integrate with?
I would keep TTL and capacity bounds as safeguards regardless. I want to
align on the expected lifecycle contract before claiming that session cleanup
is fully synchronized with chat memory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
