oscerd commented on PR #28510: URL: https://github.com/apache/camel/pull/28510#issuecomment-6437074301
Thanks @davsclaus, all requested changes have been addressed: 1. **`Subscription.cancel` body handling:** Reverted passing `getParametersFromBody(exchange)` to `cancelSub.cancel((Map<String, Object>) null, requestOptions)` so subscription cancel preserves its existing behavior of ignoring exchange body parameters. 2. **`doStop()`:** Removed `this.requestOptions = null;` to ensure in-flight requests during stop do not fall back to global SDK defaults. 3. **`StripeProducerTest` assertion:** Added `assertEquals(Stripe.LIVE_API_BASE, Stripe.getApiBase());` in `testProducerBuildsEndpointRequestOptions` verifying custom endpoint `apiBase` does not alter global `Stripe.getApiBase()`. 4. **Upgrade guide:** Wrapped lines at ~120 chars and added a migration note explaining that custom application code relying on Camel to set JVM-wide `Stripe.apiKey` must now configure the key directly or pass `RequestOptions`. 5. **Rebase:** Rebased cleanly onto latest `origin/main` (with SSH signatures preserved via `--gpg-sign`). _Claude Code on behalf of oscerd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
