oscerd commented on PR #28510: URL: https://github.com/apache/camel/pull/28510#issuecomment-6437172953
Thanks @davsclaus! All review points have been addressed and the branch has been rebased cleanly onto latest `main`: 1. **Subscription cancel parameters**: reverted to `cancelSub.cancel((Map<String, Object>) null, requestOptions)` to preserve the existing body-agnostic cancel behavior while passing the endpoint request options. 2. **`doStop()`**: removed the null-out of `requestOptions` so in-flight exchanges during shutdown continue using the endpoint options rather than falling back. 3. **Upgrade guide**: wrapped lines at ~120 characters and added a note advising users whose application code relied on `camel-stripe` setting `Stripe.apiKey` globally in the JVM to set `Stripe.apiKey` or supply `RequestOptions` explicitly. 4. **`StripeProducerTest`**: added `assertEquals(Stripe.LIVE_API_BASE, Stripe.getApiBase())` assertion in `testProducerBuildsEndpointRequestOptions`. 5. **Rebase**: rebased cleanly onto current `main`. _Claude Code on behalf of oscerd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
