Croway commented on PR #29336: URL: https://github.com/apache/camel/pull/29336#issuecomment-6687035265
@gnodet-bot thanks for the review. I checked the `doShutdown()` point against spring-jms 7.0.10, the version Camel uses, and left the lifecycle as it is: - `SingleConnectionFactory.destroy()` only calls `resetConnection()` (`SingleConnectionFactory.java` lines 358-360), and `CachingConnectionFactory` does not override `destroy()`. - `CachingConnectionFactory.resetConnection()` closes the cached sessions and the shared connection, and then sets `active = true` again (`CachingConnectionFactory.java` lines 212-234). So `destroy()` does what `doStop()` already does through `resetConnection()`: it does not make the factory refuse new connections, and a `doShutdown()` that calls it would close nothing more. Camel stops the routes, and their producers, before it stops the components, so nothing sends after `doStop()` in a normal shutdown. _Claude Code on behalf of Federico Mariani_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
