Croway commented on PR #29336:
URL: https://github.com/apache/camel/pull/29336#issuecomment-6689005713
@davsclaus thanks for the review.
**`connectionFactory` in another case:** confirmed and fixed in bf127faaeeb7.
- Reproduced on 5f0ac2c12bc5 with two embedded Artemis brokers: an endpoint
with `connectionfactory=#otherBroker` sent its message to the broker of the
component (1 message there, 0 on the other broker), because `setProperties`
binds the option without case after the `containsKey("connectionFactory")`
check.
- `AMQPComponent#createEndpoint` now decides from the connection factory the
endpoint ends up with: the one the component created, or the credentials
adapter around it. The `connectionFactory` option is also checked in any case,
because an endpoint factory given with the exact name and credentials is
wrapped in an adapter too, and the adapter does not expose its target.
- New test
`AMQPCachedConnectionTest#connectionFactoryOfTheEndpointInAnyCaseIsUsedAsIs`
(`connectionfactory`, `ConnectionFactory`, `CONNECTIONFACTORY` to a second
broker): it fails on 5f0ac2c12bc5 and passes now. camel-amqp suite: 38 tests, 0
failures.
- I also ran the suite on a merge with #29340, which shares the credentials
adapter per connection factory and credentials: 41 tests, 0 failures, including
the credentials case on the shared connection.
The other points (`sessionCacheSize`, the connection count in
`sharedConnectionIsClosedWhenTheComponentStops`, and `AMQPConnectionDetails` in
the upgrade guide) are noted and not in this PR.
_Claude Code on behalf of Federico Mariani_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
