gnodet commented on PR #29317: URL: https://github.com/apache/camel/pull/29317#issuecomment-6688941033
Thanks for the thorough review, @davsclaus! **Coordination with #29333**: You're right — the last commit (d909b2ff) overlaps with #29333 in `ScpOperations.java`. #29333 is already approved and CI-green, so the cleanest path is to merge it first and then rebase this PR on top. Once #29333 lands, I'll drop the overlapping `connectAndWrite`/`storeFile` changes from d909b2ff and keep only the `storeFileDirectly` fix and the test. **Check order in `storeFileDirectly`**: Good catch — I'll align it with `storeFile` (session null-check first, then filename check) when rebasing after #29333 merges. **Optional helper**: Agreed that `storeFile` and `storeFileDirectly` share most of their structure after the channel opens. I'll extract a small private helper (open channel → setCommand → connectAndWrite → disconnect in finally) to keep them in sync, unless you'd prefer to keep the diff minimal for now. **Backports**: Understood, keeping this to main only. _Comment posted by Guillaume Nodet on behalf of gnodet-bot (AI-assisted) — please verify before acting on any suggestion._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
