davsclaus commented on PR #29317: URL: https://github.com/apache/camel/pull/29317#issuecomment-6686669321
Heads-up from the review of #29333 (CAMEL-26066): that PR found that the scp producer must take the channel's input/output streams *before* `channel.connect()` and read the first ack of the remote scp (JSch drops data that arrives while no input stream is set, and the reads otherwise end up one ack behind). It adds `connectAndWrite` for `storeFile`. This PR makes `storeFileDirectly` connect and then call `write()`, which takes the streams after `connect()`, so the checksum file gets the same race, and `ScpProducerChecksumFileAlgorithmTest` reads the `.md5` right after the exchange, so it could flake the same way. There is no textual conflict between the two PRs, so whichever merges second should switch `storeFileDirectly` to `connectAndWrite` and drop `write()`. _Claude Code on behalf of davsclaus_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
