gnodet-bot commented on code in PR #29055:
URL: https://github.com/apache/camel/pull/29055#discussion_r4458554681
##########
components/camel-as2/camel-as2-component/src/main/java/org/apache/camel/component/as2/AS2Configuration.java:
##########
@@ -665,17 +667,38 @@ public String getAsyncMdnAllowedHosts() {
}
/**
- * Comma separated list of host names an asynchronous MDN may be delivered
to. The delivery address is chosen by the
- * sender of the AS2 message, so this is the list of hosts the operator
vouches for.
+ * Comma separated list of hosts an asynchronous MDN may be delivered to.
The delivery address is chosen by the
+ * sender of the AS2 message, so this is the list of destinations the
operator vouches for. Each entry is a host
+ * with an optional port in host:port form; an IPv6 literal is written in
square brackets, as in a URL, optionally
+ * followed by :port. A bare-host entry (for example partner.example)
matches only the default port (80), so a
+ * non-default port is listed explicitly (for example
partner.example:8443).
*
- * When set, an asynchronous MDN whose delivery address names a host
outside the list is refused, and the configured
- * mdnUserName/mdnPassword/mdnAccessToken are attached only to a host on
the list. When not set, the MDN is still
- * delivered to the sender-supplied address but no credentials are
attached.
+ * When set, an asynchronous MDN whose delivery address is not on the list
is refused, and the configured
+ * mdnUserName/mdnPassword/mdnAccessToken are attached only to an address
on the list. When not set, the MDN is
+ * still delivered to the sender-supplied address but no credentials are
attached.
*
* The option applies to the consumer endpoint it is set on: consumers
sharing a serverPortNumber each apply their
* own list.
*/
public void setAsyncMdnAllowedHosts(String asyncMdnAllowedHosts) {
this.asyncMdnAllowedHosts = asyncMdnAllowedHosts;
}
+
+ public boolean isAsyncMdnRequireHttps() {
+ return asyncMdnRequireHttps;
+ }
+
+ /**
+ * Whether an asynchronous MDN may only be delivered over https. The
delivery address, including its scheme, is
+ * chosen by the sender of the AS2 message; by default only http is
accepted (TLS delivery of asynchronous MDNs is not yet implemented). When set
to true, an
Review Comment:
The Javadoc line wraps at 161 characters. Consider splitting the
parenthetical so it reads more naturally.
```suggestion
* chosen by the sender of the AS2 message; by default only http is
accepted (TLS delivery of
* asynchronous MDNs is not yet implemented). When set to true, an
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
