Dhairya-007 commented on PR #29485: URL: https://github.com/apache/camel/pull/29485#issuecomment-6761334467
Thanks for the review, and thanks @gnodet for the `Regen` — both grammar nits are now applied: `to exists` → `to exist` and `if its true` → `if it's true`, plus `This ensure` → `This ensures` in the same clause, since it is the same sentence. I rebuilt on top of your `Regen` commit rather than on my own version of those files, so the blank line it restored before *"The option will be converted to…"* is preserved. Two things worth recording, since the duplicated line in my previous push was my fault: * The cause was my own tooling, not the build. I re-emit the wrapped javadoc by hand (no Maven available here), and I was splicing the rewrapped lines into the output list using indexes taken from the *original* list. The first block in each factory shrank from four lines to three, so every later splice landed one line early and duplicated a line. It now builds the output by appending only, and it first re-emits the unmodified file and asserts it comes back byte-for-byte identical before applying any change — which is also how I confirmed my rebuild agrees with your `Regen` output. * Your regen revealed that the committed files on `main` were missing that blank line before "The option will be converted to…", independently of this PR. My round-trip check had flagged those runs as not matching the generator and I wrongly assumed my wrapper was at fault, so I reproduced the stale form instead of questioning the committed state. Worth knowing that those two paragraphs per factory were already drifted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
