allthingssecurity commented on PR #29525: URL: https://github.com/apache/camel/pull/29525#issuecomment-6762103216
Thanks for the review. - CAMEL-19748: yes, this partly reverts it, for the reason in the description (the rethrow after the `finally` callback lets the route carry on as if the step succeeded). Happy to wait for @orpiske's ack before merge. - `AbstractApiProducer`: good catch, it has the same `catch (Exception)` plus `finally callback.done(false)` shape. I added it to the follow-up list in the description, next to `EvaluateExpressionProcessor`, the data type processors, the sync branch of `MulticastProcessor` and the reactive executor. That JIRA is next. - Upgrade guide: e237ade4b2e1 adds a paragraph saying that a test which sends with `template.send(...)` and asserts only inside a processor must now check the returned exchange's exception, or use `sendBody`/`requestBody`, which throw. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
