davsclaus commented on PR #29525: URL: https://github.com/apache/camel/pull/29525#issuecomment-6778232523
@orpiske could you take another look at fb4903ce76e3 when you have time? Your change request is still open on an earlier commit, so the PR is blocked on it. The PR now does a little less than what you agreed to at 09:39. As @allthingssecurity explains above, failing the exchange on a `VirtualMachineError` without the error handler brought back the hang this PR fixes. So the PR now leaves a `VirtualMachineError` (`OutOfMemoryError`, `StackOverflowError`, `InternalError`) exactly as on main: - All three catch sites rethrow it before `catch (Throwable)`: `DelegateSyncProcessor.java:68`, `AsyncProcessorConverterHelper.java:66` and `AbstractBeanProcessor.java:161`, the last one being the line of your thread. - Only other `Error`s (`AssertionError`, `LinkageError`, custom ones) now fail the exchange and go to the error handler. - The 4.24 upgrade guide and a new section in `error-handler.adoc` have a table of which `Error`s go where. They also recommend `-XX:+ExitOnOutOfMemoryError` / `-XX:+CrashOnOutOfMemoryError` for applications with strict reliability needs. If that addresses your concern, could you resolve your thread and update your review? _Claude Code on behalf of davsclaus_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
