gnodet-bot commented on code in PR #29450:
URL: https://github.com/apache/camel/pull/29450#discussion_r4523175636
##########
components/camel-cxf/camel-cxf-soap/src/test/java/org/apache/camel/component/cxf/jaxws/CxfProducerTest.java:
##########
@@ -236,15 +247,19 @@ protected String getJaxwsEndpointUri() {
}
protected String getWrongEndpointUri() {
- // CAMEL-26600: synchronous=true, as with the CXF async client the
callback sometimes never completes
- // when the connection fails, leaving the exchange waiting forever.
- // The async error path is not covered anymore, see CAMEL-26696
return "cxf://" + getWrongServerAddress()
+
"?serviceClass=org.apache.camel.component.cxf.jaxws.HelloService"
+ "&cxfConfigurer=#wrongServerConfigurer"
+ "&synchronous=true";
}
+ // CAMEL-26696: async (synchronous=false) wrong-server endpoint — callback
must always complete
+ protected String getWrongEndpointUriAsync() {
+ return "cxf://" + getWrongServerAddress()
Review Comment:
💡 Consider adding a `port/camel-4.22.x` label to trigger a backport: async
exchanges silently hanging forever under connection failure is a correctness
regression that LTS users should get. The fix is minimal and low-risk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
