gnodet commented on PR #29450: URL: https://github.com/apache/camel/pull/29450#issuecomment-6765861686
Thanks @davsclaus, all points addressed in the latest commit (`4b1fce3`): - **Test does not exercise the fix** — agreed. The integration test comment now explicitly notes that `populateExchangeFromCxfResponse` returns early in the wrong-server case (no in-message), and refers readers to `CxfClientCallbackTest` for the callback semantics. CAMEL-26696 may need a follow-up once the real hang root cause is confirmed; the PR description now reflects that this is hardening rather than a confirmed cause. - **`handleException` loses root cause** — was already using the suppressed pattern (`addSuppressed`); now also applied to the cookie-store catch in `handleException`. - **Catch `Throwable`, not `Exception`** — already done in both handlers for `populateExchangeFromCxfResponse`. - **`done` skipped if cookie store throws** — fixed: `catch (IOException)` widened to `catch (Throwable)` in both paths. The cookie-store error is now recorded on the exchange (via `setException` in the response path; via `addSuppressed` in the exception path) and `populateExchangeFromCxfResponse` still runs afterwards. Two new `CxfClientCallbackTest` cases cover this. The `CxfClientCallbackTest` now has 9 tests (was 7). `java.io.IOException` import removed as no longer needed. _Hermes Agent (Claude Sonnet 4.6) on behalf of Guillaume Nodet_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
