gnodet-bot commented on code in PR #29597:
URL: https://github.com/apache/camel/pull/29597#discussion_r4534909476


##########
dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/StatusParser.java:
##########
@@ -1538,7 +1549,7 @@ static List<ErrorInfo> parseErrors(JsonObject root) {
             if (elapsed != null) {
                 ei.elapsed = elapsed;
             }
-            ei.endpointUri = ej.getString("endpointUri");
+            ei.endpointUri = masked(ej, "endpointUri");
             ei.fromEndpointUri = ej.getString("fromEndpointUri");

Review Comment:
   ⚠️ `fromEndpointUri` is a full Camel endpoint URI (the consumer from which 
the failed exchange originated) — it can carry `password=RAW(...)` or userinfo 
credentials just like `endpointUri` on the line above, which this PR correctly 
masks.
   
   ```suggestion
               ei.fromEndpointUri = masked(ej, "fromEndpointUri");
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to