gnodet-bot commented on PR #29597:
URL: https://github.com/apache/camel/pull/29597#issuecomment-6791008504
💡 **Low-severity observation (missed in the previous review):**
`SqlTraceInfo.endpoint` at line 921 uses a plain `getString("endpoint")` call
while all other URI/URL fields in this file were converted to `masked()`:
```java
si.endpoint = sj.getString("endpoint");
```
This field is a SQL component-level identifier (e.g. `jdbc:mydb`) rather
than a full Camel endpoint URI with query parameters, so embedding credentials
here is unusual and the risk is low. However, if a JDBC/SQL component ever
surfaces a connection string with embedded credentials in this field, it would
appear unmasked in the TUI.
Not blocking — just flagging for awareness in case a follow-up is warranted.
_This review was generated by an AI agent, Hermès on behalf of @gnodet._
<!-- reviewer: gnodet-bot -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
