gnodet-bot commented on code in PR #29709:
URL: https://github.com/apache/camel/pull/29709#discussion_r4549296364
##########
components/camel-influxdb2/src/main/java/org/apache/camel/component/influxdb2/InfluxDb2Endpoint.java:
##########
@@ -79,7 +79,11 @@ public class InfluxDb2Endpoint extends DefaultEndpoint {
@UriParam
@Metadata(required = true, description = "The name of the bucket where the
time series will be stored.")
private String bucket;
- @UriParam(defaultValue = "default", description = "Define the retention
policy to the data created by the endpoint.")
+ @UriParam(defaultValue = "default", description = "(deprecated) Never
read: InfluxDB 2.x has no per-write"
+ + " retention policy.")
+ @Metadata(deprecationNote = "Never read by the component: the InfluxDB 2.x
write API has no retention policy,"
+ + " retention is a property of the bucket")
+ @Deprecated
private String retentionPolicy = "default";
Review Comment:
`@Deprecated` is placed on the private field, but the public accessors
`getRetentionPolicy()` / `setRetentionPolicy()` are not in this diff and will
remain unannotated. Java's `@Deprecated` does not propagate from a field to its
getters/setters — callers won't see a compiler warning.
Please add `@Deprecated` (and a `@deprecated` Javadoc tag) to both methods.
##########
components/camel-influxdb2/src/main/java/org/apache/camel/component/influxdb2/InfluxDb2Endpoint.java:
##########
@@ -79,7 +79,11 @@ public class InfluxDb2Endpoint extends DefaultEndpoint {
@UriParam
@Metadata(required = true, description = "The name of the bucket where the
time series will be stored.")
private String bucket;
- @UriParam(defaultValue = "default", description = "Define the retention
policy to the data created by the endpoint.")
+ @UriParam(defaultValue = "default", description = "(deprecated) Never
read: InfluxDB 2.x has no per-write"
+ + " retention policy.")
+ @Metadata(deprecationNote = "Never read by the component: the InfluxDB 2.x
write API has no retention policy,"
+ + " retention is a property of the bucket")
+ @Deprecated
private String retentionPolicy = "default";
Review Comment:
`@Deprecated` is placed on the private field, but the public accessors
`getRetentionPolicy()` / `setRetentionPolicy()` are not in this diff and will
remain unannotated. Java's `@Deprecated` does not propagate from a field to its
getters/setters — callers won't see a compiler warning.
Please add `@Deprecated` (and a `@deprecated` Javadoc tag) to both methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
