Dhairya-007 commented on PR #29709:
URL: https://github.com/apache/camel/pull/29709#issuecomment-6825215723

   All three points are in, thanks — and sorry it took a second pass on the 
accessors; the bot raised it twice and I missed that `@Deprecated` on a private 
field does not reach them.
   
   **The accessors are deprecated.** `getRetentionPolicy()` and 
`setRetentionPolicy()` now both carry `@Deprecated` and a `@deprecated` tag, in 
the `DoclingConfiguration#apiKeyHeader` shape:
   
   ```java
   /**
    * @deprecated Never read by the component: the InfluxDB 2.x write API has 
no retention policy, retention is a
    *             property of the bucket
    */
   @Deprecated
   public String getRetentionPolicy() {
   ```
   
   **Rebased on main.** The only conflict was the one you predicted, in 
`camel-4x-upgrade-guide-4_24.adoc`: main has since appended the `camel-docling` 
OCR-headers entry. Resolved by keeping that one first and my section after it. 
`git merge-tree` is clean now.
   
   **The doubled wording is gone** — good catch, it read badly. Both 
descriptions go back to their original text ("Define the retention policy to 
the data created by the endpoint." and "The string that defines the retention 
policy to the data created by the endpoint"), so the generated text is now the 
docling shape: the original description plus `Deprecation note: …` once, rather 
than saying "never read" twice. Propagated to both JSON copies and the two DSL 
javadoc blocks — the option method and the `influxdbRetentionpolicy()` header 
method, which shared one wrapped paragraph before and now differ. The two JSON 
copies are byte-identical afterwards.
   
   The `@Deprecated` the regen added to `influxdbRetentionpolicy()` is 
untouched.
   
   **JIRA** — still no credentials for issues.apache.org here; a committer 
creating the ticket (or giving me the number) is all I need to retitle and 
amend.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to