gnodet-bot commented on code in PR #30008: URL: https://github.com/apache/camel/pull/30008#discussion_r4578135158
########## docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_24.adoc: ########## @@ -350,6 +350,13 @@ is skipped. Before, the source transaction was rolled back and the record replay the route of the send (for example with `direct`) behaves the same way, as it did in 4.23. To replay the record, throw the exception again in the `doCatch` block, or end it with `rollback()`. +=== camel-kafka - the asynchronous manual commit is done by the consumer thread + +With the `DefaultKafkaManualAsyncCommitFactory`, `KafkaManualCommit.commit()` records the offset, and the consumer +thread commits it before its next poll, as in Camel 4.21. In Camel 4.22 and 4.23 the commit was done at once on the +calling thread, which failed with a `ConcurrentModificationException` when that was not the consumer thread, for +example after an aggregator. Review Comment: The sentence at lines 356–358 runs 36 words — split it for readability. ```suggestion thread commits it before its next poll, as in Camel 4.21. In Camel 4.22 and 4.23, the commit ran at once on the calling thread. That failed with a `ConcurrentModificationException` when the calling thread was not the consumer thread (for example, after an aggregator). ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
