gnodet-bot commented on code in PR #30008: URL: https://github.com/apache/camel/pull/30008#discussion_r4578828759
########## docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_22.adoc: ########## @@ -766,6 +766,15 @@ relied on the setter being inert until an exchange arrived must be aware of the Setting `keepOpen` back to `false` remains deferred: the half-open timer attempts to close the circuit on its next tick (after `halfOpenAfter` milliseconds, default 30 s). +=== camel-kafka - the asynchronous manual commit is done by the consumer thread + +With the `DefaultKafkaManualAsyncCommitFactory`, `KafkaManualCommit.commit()` records the offset, and the consumer +thread commits it before its next poll, as in Camel 4.21. In Camel 4.22.0 to 4.22.2, the commit ran at once on the +calling thread. That failed with a `ConcurrentModificationException` when the calling thread was not the consumer +thread (for example, after an aggregator). +A commit called after the partition was revoked from the consumer is not made, so it does not move back the offset +that the new owner of the partition committed. + Review Comment: 💡 **Doc nit (low):** This sentence runs 30 words — just over the 25-word guideline. Split suggestion: ```suggestion A commit called after the partition is revoked is not made. This prevents it from moving back the offset that the new owner of the partition committed. ``` ########## docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_24.adoc: ########## @@ -350,6 +350,15 @@ is skipped. Before, the source transaction was rolled back and the record replay the route of the send (for example with `direct`) behaves the same way, as it did in 4.23. To replay the record, throw the exception again in the `doCatch` block, or end it with `rollback()`. +=== camel-kafka - the asynchronous manual commit is done by the consumer thread + +With the `DefaultKafkaManualAsyncCommitFactory`, `KafkaManualCommit.commit()` records the offset, and the consumer +thread commits it before its next poll, as in Camel 4.21. In Camel 4.23 (and 4.22 before 4.22.3), the commit ran at +once on the calling thread. That failed with a `ConcurrentModificationException` when the calling thread was not the +consumer thread (for example, after an aggregator). +A commit called after the partition was revoked from the consumer is not made, so it does not move back the offset +that the new owner of the partition committed. + Review Comment: 💡 **Doc nit (low):** Same sentence, same nit — 30 words. Split suggestion: ```suggestion A commit called after the partition is revoked is not made. This prevents it from moving back the offset that the new owner of the partition committed. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
