Dhairya-007 opened a new pull request, #30092:
URL: https://github.com/apache/camel/pull/30092

   ## Problem
   
   The instance-tags header names its element type by simple name only:
   
   ```java
   @Metadata(description = "A collection of tags to add or remove from EC2 
resources", javaType = "Collection<Tag>")
   public static final String INSTANCES_TAGS = "CamelAwsEC2InstancesTags";
   ```
   
   ```json
   "CamelAwsEC2InstancesTags": { ..., "javaType": "Collection<Tag>", ... }
   ```
   
   `Tag` is `software.amazon.awssdk.services.ec2.model.Tag`. Each AWS service 
SDK ships its own `Tag`, so the simple name does not narrow it down even once a 
reader knows it is an AWS class - and within this catalog the same bare `Tag` 
is already used for a different class, `io.micrometer.core.instrument.Tag` in 
`camel-micrometer`'s tags header.
   
   It is also the only header in this component whose type is not a `String`, 
so it is the single entry in the table where the type matters.
   
   Fully qualified is the convention by a wide margin across the catalog: 3692 
header `javaType` values are fully qualified or a built-in type, and 151 are 
not.
   
   ## Fix
   
   Qualify the element type to 
`Collection<software.amazon.awssdk.services.ec2.model.Tag>`, the FQN the 
component's own sources import. `Collection` keeps its bare spelling, matching 
the rest of the catalog, and the header name is untouched.
   
   Metadata only - no behaviour change. I diffed the regenerated catalog file 
against `main` and confirmed this one `javaType` value is the only field that 
differs.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to