allthingssecurity commented on PR #30138:
URL: https://github.com/apache/camel/pull/30138#issuecomment-6912880342

   Thanks for checking the Paho parts against the 1.2.5 sources, Claus. Pushed 
f60abe1e3dfc.
   
   1. **[Important] JIRAs for the two cases:** agreed. The drafts are written: 
the callback-thread hang, marked as needing a reproduction and maybe an 
upstream Paho issue, and the stop while the client connects, which has a plain 
test against the real Paho client and a fix in preparation. They will be filed 
shortly, and a follow-up commit will name the keys in the world Javadoc, next 
to the two properties and in test-dst.adoc. I kept that out of this commit so 
the rest is not held up.
   2. **[Suggestion] `delivered()` and `Starting`:** fixed. A message counts as 
delivered while the route stops only when the world stops the route, the 
consumer restarts it after a failed subscribe, or the route status is 
`Stopping` or `Stopped`; `Starting` no longer counts, so a consumer that 
dropped the messages of a kept session while its route starts would fail the 
seed. The excuses in `acknowledged()` and `missing()` use the same set, so they 
are narrowed too. The default set still passes 5000 of 5000 seeds with it.
   3. **[Nit] Paho 1.2.5 details in `FakeMqtt`:**
      - the `[P]` note at `messageArrived` now says that in v5 
`CommsCallback.deliverMessage` catches and ignores an `Exception` (only an 
`Error` closes the connection), and that the fake still counts it because the 
consumer should not throw one;
      - `everReconnected` is now `reconnecting`, set at the first lost 
connection with `automaticReconnect`, as `MqttReconnectCallback.disconnected()` 
does (checked with javap), and no longer after a successful reconnect;
      - "not modelled" now says the fake frees the Receive Maximum slot of a 
QoS 2 message at PUBREC, one round trip before PUBCOMP, where MQTT 5 ยง4.9 
returns it.
   4. **[Nit] `startRoute` and `dst.executor("operator", 1)`:** the world keeps 
the operator executor in a field and a failed start is retried on it, so the 
trace has one "operator" executor and the retry is serialized with the operator.
   5. **[Suggestion] test-dst.adoc:** the "Running the tests" section (and its 
catalog copy) now has a paragraph for camel-paho-mqtt5 with the self-check 
commits (main code of 6044f38166f9 for CAMEL-25944, and the change of 
b7594f06e0b7 for CAMEL-25793, taken out by hand) and the two `dst.paho.*` 
properties.
   
   Tests: `PahoMqtt5ConsumerDstTest` passes 5000 of 5000 seeds, and the 
camel-paho-mqtt5 unit tests pass (5075 run with those seeds, 0 failures).
   
   _Claude Code on behalf of allthingssecurity_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to