allthingssecurity commented on PR #30138: URL: https://github.com/apache/camel/pull/30138#issuecomment-6916358381
Thanks, Claus. Pushed b7dce9d59c84 and 06a0f1f76a1a. 1. **JIRAs for the two cases:** filed. The callback-thread hang is [CAMEL-27043](https://issues.apache.org/jira/browse/CAMEL-27043), marked as needing a reproduction and maybe a Paho issue, and the stop while the client connects is [CAMEL-27041](https://issues.apache.org/jira/browse/CAMEL-27041), with a plain test against the real Paho client. The keys are in the world Javadoc (`PahoMqtt5World.java:66`), next to the two properties, in test-dst.adoc (and its catalog copy) and in the issues of `@DstWorld`, with the component JSON, its catalog copy and the table regenerated. The PR description names them too. 2. **The last commit:** done as you suggest. b7dce9d59c84 reverts c604c813 (no force-push, so the commit stays in the history; its message, with the two `CAMEL-XXXXX` placeholders, should be left out of the squash message). The fake changes move to the two consumer fixes that need them (CAMEL-27042, a SUBACK failure code that is ignored, and CAMEL-27041), as a test-only change that whichever of this PR and each fix merges second carries. Both fidelity points are fixed in it: - `:737`: a forced disconnect during an automatic reconnect now fails that attempt and reschedules the cycle, as `MqttReconnectActionListener.onFailure` calls `rescheduleReconnectCycle` (checked with javap on 1.2.5); a closed client ends the cycle at its next attempt. - `:433`: the `finally` clears `connecting` only when no forced disconnect came during that connect (`forced == forcedDisconnects`), so an older connect no longer clears the flag of a newer one. The reconnect does the same. With that change and both fixes merged locally on this head: the default set passes 5000 of 5000 seeds (module 5084 run, 0 failures), and `-Ddst.paho.stopWhileConnecting=true` passes 5000 of 5000. 3. **Merge order:** agreed, the "Running the tests" paragraphs of #30137 and #30138 conflict. Whichever of the two merges second, we merge main into it and resolve the paragraph (and its catalog copy). The PR description no longer claims a clean merge with #30137. Tests on this head: `PahoMqtt5ConsumerDstTest` passes 5000 of 5000 seeds, and the camel-paho-mqtt5 unit tests pass (5075 run with those seeds, 0 failures). _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
