oscerd commented on PR #29821: URL: https://github.com/apache/camel/pull/29821#issuecomment-6942908640
Rebased on `main` (CAMEL-26834 landed last night) and pushed `CAMEL-26833: The readiness check watches the identity the producer serves, and the stop closes the observer client whatever the repository does` (801b2b6751ce): - **Hand-over with #29822**: `SpiffeProducerHealthCheck` takes the producer's `localSpiffeId` and, when it is set, follows `SpiffeX509SvidSelector.select(update.getX509Svids(), localSpiffeId)` instead of `getDefaultSvid()`, so readiness reports the identity the producer actually serves; an update that no longer carries it is unusable material, not a fallback to the default. The check publishes `spiffe.localSpiffeId` in its details, and `watchesTheConfiguredLocalIdentityInsteadOfTheDefault` covers both the selected identity and its removal. The doc bullet says which identity is observed. - **`doStop`**: the health-check cleanup sits in an inner `try`, whose `finally` closes the observer client, so a repository that throws can neither keep the client open nor skip `super.doStop()`, as you suggested. - The generated metadata is regenerated on top of main (the health options and `localSpiffeId` are both in `spiffe.json`); the DSL factories follow from the CI regen step. Unit tests green locally. _Claude Code on behalf of oscerd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
