davsclaus commented on code in PR #30369:
URL: https://github.com/apache/camel/pull/30369#discussion_r4626284624


##########
docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_24.adoc:
##########
@@ -214,6 +214,16 @@ option from the JAXB data format configured on the 
CamelContext (such as `camel.
 
 The SOAP data format (camel-soap) is built on the JAXB data format, and always 
ignores these headers.
 
+=== camel-google-drive, camel-google-mail - the OAuth access token is sent 
only in the Authorization header
+
+The producers of `google-drive` and `google-mail` no longer copy the 
`accessToken` option onto the request as the

Review Comment:
   The wording is on purpose. The consumers pass only the method arguments 
(`getEndpointProperties()`), not the configuration properties, so the token 
never reached their requests; only the producers of drive and mail sent 
`access_token`. The consumers and calendar now use the shared helper for 
consistency, which the PR description says.
   
   _Claude Code on behalf of Claus Ibsen_



##########
docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_24.adoc:
##########
@@ -214,6 +214,16 @@ option from the JAXB data format configured on the 
CamelContext (such as `camel.
 
 The SOAP data format (camel-soap) is built on the JAXB data format, and always 
ignores these headers.
 
+=== camel-google-drive, camel-google-mail - the OAuth access token is sent 
only in the Authorization header
+
+The producers of `google-drive` and `google-mail` no longer copy the 
`accessToken` option onto the request as the
+`access_token` query parameter of the Google API. The access token is sent in 
the `Authorization` header by the OAuth
+credential of the client, as before, so the request URL no longer carries it. 
The other credential options
+(`clientId`, `clientSecret`, `refreshToken`, `serviceAccountKey` and 
`delegate`) are not set on the request either.
+A `CamelGoogleDrive.accessToken` or `CamelGoogleMail.accessToken` header is 
ignored for the same reason; use a
+separate endpoint with its own `accessToken` to call with another token. 
`google-calendar` follows the same rule; its
+requests had no `access_token` parameter.

Review Comment:
   `CalendarRequest` (google-api-services-calendar v3-rev20251207-2.0.0) has no 
`setAccessToken`, so the bean introspection loop could not set an 
`access_token` parameter there; `GoogleCalendarRequestCredentialTest` passes on 
the old code too and is a regression guard (the PR description says so). So the 
guide sentence is accurate.
   
   _Claude Code on behalf of Claus Ibsen_



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to