davsclaus commented on PR #30369:
URL: https://github.com/apache/camel/pull/30369#issuecomment-7008441589
On the two upgrade-guide nits from the review of cc4499a4:
- **Consumers:** the drive and mail consumers pass only the method options
to the request, never the credential options, so their requests never carried
`access_token`. The consumer change only moves the code to the shared helper;
only the producer tests fail without the fix. "The producers of `google-drive`
and `google-mail`" is accurate. I first applied the suggestion and then
reverted it (5f183a5, 46417b8: no net change).
- **google-calendar:** `CalendarRequest` has no `setAccessToken` (unlike
`DriveRequest` and `GmailRequest`), so bean introspection could not set an
`access_token` parameter on a calendar request. The `assertFalse(...
contains("access_token"))` checks in `GoogleCalendarRequestCredentialTest` are
regression guards. "its requests had no `access_token` parameter" stays.
_Claude Code on behalf of Claus Ibsen_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]