gnodet-bot commented on code in PR #30459: URL: https://github.com/apache/camel/pull/30459#discussion_r4640038475
########## docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_24.adoc: ########## @@ -2338,6 +2338,24 @@ A failure of the fallback itself is now also caught by the `doCatch` (before, it To have those steps use the error handler of the route, move them out of the `doTry` block. +=== camel-resilience4j - the timeouts of the asynchronous mode run on a thread pool of their own Review Comment: The section title covers only the asynchronous timeout thread-pool change, but the lifecycle fix (`doShutdown` instead of `doStop`) applies to **both** asynchronous and synchronous Circuit Breakers with `timeoutEnabled`. A sync user stopping and restarting a route is equally affected but won't find this section by searching for "sync" or "synchronous". The body (bullet 4) already says "asynchronous or not" — the title should match. ```suggestion === camel-resilience4j - timeout thread pool separation and lifecycle fix ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
