allthingssecurity commented on PR #30459:
URL: https://github.com/apache/camel/pull/30459#issuecomment-7034274625

   Thanks for the review and for the rebase.
   
   1. CI on your rebased head 649fd116 is green (Build and test, doc 
validation, license check, dependency review). No run has started yet on the 
follow-up head f9f7c65e; I'll check it once it does.
   2. Doc caveat added in `resilience4j-eip.adoc` and its catalog copy 
(f9f7c65e151b): after a timeout the fallback and the rest of the route run on a 
`CircuitBreakerTimeout` thread, that pool has the size of the default thread 
pool profile (10), so keep the fallback non-blocking or give that pool enough 
threads. Handing the continuation off the scheduler thread after a timeout I 
would leave as a follow-up, since it changes which thread runs the rest of the 
route.
   3. Upgrade guide entry added in `camel-4x-upgrade-guide-4_24.adoc`, next to 
the other camel-resilience4j section, with your four points: the extra 
`CircuitBreakerTimeout` pool, `timeoutExecutorService` now runs only the calls, 
the continuation after a timeout runs on the new thread, and the thread pools 
stay until the route is removed (same commit).
   4. New `ResilienceThreadPoolLifecycleTest` (same commit): a sync and an 
async route with a timeout, the thread pools are recorded through the 
`ExecutorServiceManager`. After `stopRoute` none of them is shut down (the 
calls pool of both modes and the `CircuitBreakerTimeout` scheduler), after 
`removeRoute` all of them are. `shutdownNow` happens inside `removeRoute`, so 
no Awaitility was needed. With the processor and reifier of main it fails (the 
calls pool is shut down by `stopRoute`), with the PR it passes.
   5. Agreed, left for the follow-up together with the 
`ForkJoinPool.commonPool()` description and the regen.
   
   Tests: camel-resilience4j 102 run, 0 failures; 
`ResilienceThreadPoolLifecycleTest` 20 times in one JVM, 20 run, 0 failures.
   
   _Claude Code on behalf of allthingssecurity_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to