orpiske commented on a change in pull request #66: Added support for testing the Kafka service using Strimzi URL: https://github.com/apache/camel-kafka-connector/pull/66#discussion_r364952306
########## File path: tests/src/test/java/org/apache/camel/kafkaconnector/services/kafka/ZookeeperContainer.java ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.camel.kafkaconnector.services.kafka; + +import java.util.function.Consumer; +import com.github.dockerjava.api.command.CreateContainerCmd; +import org.testcontainers.containers.GenericContainer; +import org.testcontainers.containers.Network; +import org.testcontainers.containers.wait.strategy.Wait; + +public class ZookeeperContainer extends GenericContainer { + private static final String ZOOKEEPER_CONTAINER = "strimzi/kafka:0.11.4-kafka-2.1.0"; + private static final int ZOOKEEPER_PORT = 2181; + + public ZookeeperContainer(Network network, String name) { + super(ZOOKEEPER_CONTAINER); + + withEnv("LOG_DIR", "/tmp/logs"); + withExposedPorts(ZOOKEEPER_PORT); + withNetwork(network); + withCreateContainerCmdModifier( + new Consumer<CreateContainerCmd>() { + @Override + public void accept(CreateContainerCmd createContainerCmd) { + createContainerCmd.withHostName(name); + createContainerCmd.withName(name); + } + } + ); + + withCommand( "sh", "-c", + "bin/zookeeper-server-start.sh config/zookeeper.properties"); + } Review comment: I think we'll need a waitingFor(Wait.forListeningPort()) here, so that it waits for the container to go up. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
