orpiske commented on a change in pull request #66: Added support for testing the Kafka service using Strimzi URL: https://github.com/apache/camel-kafka-connector/pull/66#discussion_r365570628
########## File path: tests/src/test/java/org/apache/camel/kafkaconnector/services/kafka/StrimziContainer.java ########## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.camel.kafkaconnector.services.kafka; + +import java.util.function.Consumer; +import com.github.dockerjava.api.command.CreateContainerCmd; +import org.testcontainers.containers.GenericContainer; +import org.testcontainers.containers.Network; +import org.testcontainers.containers.wait.strategy.Wait; + +public class StrimziContainer extends GenericContainer { + private static final String STRIMZI_CONTAINER = System.getProperty("itest.strimzi.container.image"); + private static final int KAFKA_PORT = 9092; + + public StrimziContainer(Network network, String name) { + super(STRIMZI_CONTAINER); + + withEnv("LOG_DIR", "/tmp/logs"); + withExposedPorts(KAFKA_PORT); Review comment: It works because of the call to [addFixedExposedPort(KAFKA_PORT, KAFKA_PORT)](https://github.com/apache/camel-kafka-connector/pull/66/commits/75e8953c0f3d224d1c1e9309bd3dc7ebd5d24bfc#diff-98b65a9f0c00948336e48a4237b379e5R65) on the start() method. Maybe we should add a comment here, but the explanation is that this makes the port mapping from the localhost to inside the container to use the same standard Kafka port (i.e: like running docker -p 9092:9092). The usage of withExposedPort will configure it to use a dynamic port which may require further configuration on the Kafka client. The addFixedExposedPort is the default behaviour for the Kafka container, which is why I had originally used it here as well. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
