[
https://issues.apache.org/jira/browse/CASSANDRA-767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853495#action_12853495
]
Gary Dusbabek commented on CASSANDRA-767:
-----------------------------------------
Looking good. A few minor things:
FBUtilities: got rid of readNullableString, but not writeNullableString. It
looks like mapToString is unused as well.
Filters: I think there is still some more work that can be done here to get rid
of string-keys (get rid of getHashBuckets and rework filter tests so that they
iterate through byte[] and not String for keys).
RandomPartitioner: it wouldn't take a lot of work to get rid of DELIMITER.
When CASSANDRA-953 is done, we'll not have string keys anywhere, right? That
includes RowMutation, DecoratedKey, storage APIs, the works?
> Row keys should be byte[]s, not Strings
> ---------------------------------------
>
> Key: CASSANDRA-767
> URL: https://issues.apache.org/jira/browse/CASSANDRA-767
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Stu Hood
> Assignee: Stu Hood
> Priority: Critical
> Fix For: 0.7
>
> Attachments: 0001-Implement-compaction-benchmark.patch,
> 0002-Implement-a-legacy-sstable-test.patch,
> 0003-Store-bytes-in-DecoratedKey-and-cleanup-dead-code.patch,
> 0004-Extract-read-writeName.patch,
> 0005-Convert-IPartitioner-disk-key-format-to-bytes.patch,
> 0006-Bump-SSTable-version-to-c-remove-utf16-encoding-from.patch
>
>
> This issue has come up numerous times, and we've dealt with a lot of pain
> because of it: let's get it knocked out.
> Keys being Java Strings can make it painful to use Cassandra from other
> languages, encoding binary data like integers as Strings is very inefficient,
> and there is a disconnect between our column data types and the plain String
> treatment we give row keys.
> The key design decision that needs discussion is: Should we apply the column
> AbstractTypes to row keys? If so, how do Partitioners change?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
