[
https://issues.apache.org/jira/browse/CASSANDRA-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stu Hood updated CASSANDRA-767:
-------------------------------
Attachment: 0005-Convert-IPartitioner-disk-key-format-to-bytes.patch
> FBUtilities: got rid of readNullableString, but not writeNullableString. It
> looks like mapToString is unused as well.
Attaching a new copy of 0005 that kills those as well.
> Filters: I think there is still some more work that can be done here to get
> rid of string-keys
This is coming in 953... unfortunately, I underestimated how large it would
get, but I think I've kept it relatively compartmentalized.
> RandomPartitioner: it wouldn't take a lot of work to get rid of DELIMITER.
Yes, but it would require conditional behaviour in RandomPartitioner.convert*
based on the SSTable version, which isn't fun. I'd prefer to do that in another
patch if possible: perhaps one that removes the 'convertToDisk' methods
entirely.
> When CASSANDRA-953 is done, we'll not have string keys anywhere, right?
Correct: it's a larger patchset than I expected, but it is almost finished.
> Row keys should be byte[]s, not Strings
> ---------------------------------------
>
> Key: CASSANDRA-767
> URL: https://issues.apache.org/jira/browse/CASSANDRA-767
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Stu Hood
> Assignee: Stu Hood
> Priority: Critical
> Fix For: 0.7
>
> Attachments: 0001-Implement-compaction-benchmark.patch,
> 0002-Implement-a-legacy-sstable-test.patch,
> 0003-Store-bytes-in-DecoratedKey-and-cleanup-dead-code.patch,
> 0004-Extract-read-writeName.patch,
> 0005-Convert-IPartitioner-disk-key-format-to-bytes.patch,
> 0006-Bump-SSTable-version-to-c-remove-utf16-encoding-from.patch
>
>
> This issue has come up numerous times, and we've dealt with a lot of pain
> because of it: let's get it knocked out.
> Keys being Java Strings can make it painful to use Cassandra from other
> languages, encoding binary data like integers as Strings is very inefficient,
> and there is a disconnect between our column data types and the plain String
> treatment we give row keys.
> The key design decision that needs discussion is: Should we apply the column
> AbstractTypes to row keys? If so, how do Partitioners change?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
