[
https://issues.apache.org/jira/browse/CASSANDRA-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861974#action_12861974
]
Stu Hood commented on CASSANDRA-1024:
-------------------------------------
Hey Ryan, this looks good.
As discussed in IRC, can you:
* Use Arrays.binarySearch in EstimatedHistogram
* Either statically calculate or explain in a comment the calculation of the
buckets
* I don't think it is a big deal, but in EstimatedHistogram.get(boolean), you
swap the reference to the buckets without synchronization. The caller should
just get the missed updates the next time he comes around.
Also, would you mind cleaning this up for
http://wiki.apache.org/cassandra/CodeStyle a little bit?
Thanks!
> Latency Histograms
> ------------------
>
> Key: CASSANDRA-1024
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1024
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Ryan King
> Assignee: Ryan King
> Priority: Minor
> Attachments: 1024.patch
>
>
> In addition to total and recent latency, I would like to keep track of
> histograms. We have a way for doing estimated histograms (whose error domain
> gets worse the higher the latency and whose storage requirements are
> constant). It works pretty well for us:
>
> http://github.com/robey/ostrich/blob/master/src/main/scala/com/twitter/ostrich/Histogram.scala
> I'm planning on doing the work, but wanted to know if it would be useful to
> others.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
