[
https://issues.apache.org/jira/browse/CASSANDRA-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jonathan Ellis resolved CASSANDRA-1024.
---------------------------------------
Resolution: Fixed
committed w/ a few changes:
- removed unused percentile code (not because it was bad, but precisely b/c it
was unused)
- made buckets final, returning a new long[] in get(). this avoids the
serialization problem w/o a performance hit on the common operation, in
exchange for slightly more work on the uncommon one. w/o serialization other
threads could continue to use the old reference for an arbitrarily long time;
less importantly, it's best to not allow your caller to mutate your internal
state if it can be avoided; returning a new long[] preserves encapsulation.
- finished cleaning up brace placement, redundant use of "this", etc.
> Latency Histograms
> ------------------
>
> Key: CASSANDRA-1024
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1024
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Ryan King
> Assignee: Ryan King
> Priority: Minor
> Attachments: 1024.patch
>
>
> In addition to total and recent latency, I would like to keep track of
> histograms. We have a way for doing estimated histograms (whose error domain
> gets worse the higher the latency and whose storage requirements are
> constant). It works pretty well for us:
>
> http://github.com/robey/ostrich/blob/master/src/main/scala/com/twitter/ostrich/Histogram.scala
> I'm planning on doing the work, but wanted to know if it would be useful to
> others.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
