[
https://issues.apache.org/jira/browse/CASSANDRA-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12873037#action_12873037
]
Jonathan Ellis commented on CASSANDRA-1117:
-------------------------------------------
I think we can get this in if you can fix the speed regression.
All that should be needed is a single-level ArrayList to bsearch on. You're
not doing anything fancy with the TreeMap, just using floor. bsearch on an
array will be much more cache-coherent.
The Builder pattern seems overwrought here. I'd rather see MappedSegmentedFile
and BufferedSegmented file, with
addPotentialBoundary/completeBoundaryConstruction pushed into SF as abstract.
Patches 01 04 05 are not core to cleaning up mmap, and move things around
without any real benefit. Let's leave those out.
> Clean up MMAP support
> ---------------------
>
> Key: CASSANDRA-1117
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1117
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Stu Hood
> Assignee: Gary Dusbabek
> Fix For: 0.7
>
> Attachments: 0001-Use-factory-functions-for-RowIndexedReader.patch,
> 0002-Add-SegmentedFile-to-abstract-opening-FileDataInputs.patch,
> 0003-Replace-mmap-file-abstraction-with-SegmentedFile.patch,
> 0004-Rename-SSTableReaderTest-to-SegmentedFileTest.patch,
> 0005-Remove-filename-munging.patch
>
>
> Awareness of MMAP is currently embedded into the SSTableReader implementation
> and IndexSummary. A good number of bugs experienced recently have been due to
> this lack of separation, so it is ripe for abstraction. Additionally, the
> current implementation does not provide a good method for iterating over the
> segments of a file, which is useful for range queries, and lays more stable
> groundwork for #998.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
