[ 
https://issues.apache.org/jira/browse/CASSANDRA-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stu Hood updated CASSANDRA-1117:
--------------------------------

    Attachment: 0004-Remove-filename-munging.patch

* Replaced TreeMap with an Array of final 'Segment' objects
** (now very slightly faster than trunk)
* Rebased for trunk
* Removed the patch renaming SSTableReaderTest to SegmentedFileTest

I didn't remove the builder pattern, because the alternative seems pretty ugly 
(copying the segments array for every append). The accessory patches address 
minor issues that aren't worth opening tickets for, but I can remove them if 
you're sure we don't want them.

> Clean up MMAP support
> ---------------------
>
>                 Key: CASSANDRA-1117
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1117
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Stu Hood
>            Assignee: Gary Dusbabek
>             Fix For: 0.7
>
>         Attachments: 0001-Use-factory-functions-for-RowIndexedReader.patch, 
> 0002-Add-SegmentedFile-to-abstract-opening-FileDataInputs.patch, 
> 0003-Replace-mmap-file-abstraction-with-SegmentedFile.patch, 
> 0004-Remove-filename-munging.patch
>
>
> Awareness of MMAP is currently embedded into the SSTableReader implementation 
> and IndexSummary. A good number of bugs experienced recently have been due to 
> this lack of separation, so it is ripe for abstraction. Additionally, the 
> current implementation does not provide a good method for iterating over the 
> segments of a file, which is useful for range queries, and lays more stable 
> groundwork for #998.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to