[ 
https://issues.apache.org/jira/browse/CASSANDRA-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908847#action_12908847
 ] 

Jon Hermes commented on CASSANDRA-1480:
---------------------------------------

(This code is only touched in describe keyspace(s) in the API.)
Attaching a debugger shows the subcomparator_type of the result of the call to 
be null (as expected) until it gets sent, at which point the result is then 
converted to the empty string.
I'm not sure when this behaviour changed, but it appears to be systemic and not 
a simple error.

It would be less time to change the code to accept the empty string (which may 
come up naturally anyway) than it would be to continue debugging thrift.

> CFMetaData.convertToThrift makes subcomparator_type empty string instead of 
> null
> --------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1480
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1480
>             Project: Cassandra
>          Issue Type: Bug
>          Components: API
>    Affects Versions: 0.7 beta 1
>            Reporter: Jeremy Hanna
>            Assignee: Jon Hermes
>             Fix For: 0.7 beta 2
>
>
> As a result of CASSANDRA-891 adding a CFMetaData.convertToThrift method, the 
> values such as subcomparator_type are defaulted to empty string instead of 
> null.  That makes it so, for example, in ColumnFamilyRecordReader, in its 
> RowIterator, the check for only null is insufficient.  It also needs to check 
> for a blank value.
> After a discussion about it in IRC, Jonathan said it was probably easier to 
> just change the creation to give a null value instead of empty string.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to