[ 
https://issues.apache.org/jira/browse/CASSANDRA-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jon Hermes updated CASSANDRA-1480:
----------------------------------

    Attachment: 1480.txt

convertToCFMetaData had to be changed as well, it was expecting subcomparator 
to default to empty string. I don't think this was a recent change; instead it 
looks more like we changed our assumpting about the default.

In any event, subcomp, reconciler, and comment all default to null now and all 
tests/methods are working correctly.

> CFMetaData.convertToThrift makes subcomparator_type empty string instead of 
> null
> --------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1480
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1480
>             Project: Cassandra
>          Issue Type: Bug
>          Components: API
>    Affects Versions: 0.7 beta 1
>            Reporter: Jeremy Hanna
>            Assignee: Jon Hermes
>             Fix For: 0.7 beta 2
>
>         Attachments: 1480.txt
>
>
> As a result of CASSANDRA-891 adding a CFMetaData.convertToThrift method, the 
> values such as subcomparator_type are defaulted to empty string instead of 
> null.  That makes it so, for example, in ColumnFamilyRecordReader, in its 
> RowIterator, the check for only null is insufficient.  It also needs to check 
> for a blank value.
> After a discussion about it in IRC, Jonathan said it was probably easier to 
> just change the creation to give a null value instead of empty string.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to