[ 
https://issues.apache.org/jira/browse/CASSANDRA-7563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14213046#comment-14213046
 ] 

Tyler Hobbs commented on CASSANDRA-7563:
----------------------------------------

Good work so far!  Here's my preliminary feedback:
* Using {{ProtocolVersion.NEWEST_SUPPORTED}} for serializing and deserializing 
is not correct.  (I noticed a similiar issue when working on json functions.)  
The protocol version used by the current connection needs to be passed into 
function executions for proper serialization and deserialization.
* Can you add test cases for calling a UDF on a collection type with a null 
value (empty cell)?  The code looks like it should handle this, but it's good 
to test.
* The new unit tests are really hard to parse.  Do you have any ideas for 
making them a little more readable?
*  Do you already have a C* ticket open for replacing the reflection calls 
after JAVA-502 is done?  If not, can you go ahead and make that?

> UserType, TupleType and collections in UDFs
> -------------------------------------------
>
>                 Key: CASSANDRA-7563
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7563
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Robert Stupp
>            Assignee: Robert Stupp
>             Fix For: 3.0
>
>         Attachments: 7563-7740.txt, 7563.txt, 7563v2.txt, 7563v3.txt
>
>
> * is Java Driver as a dependency required ?
> * is it possible to extract parts of the Java Driver for UDT/TT/coll support ?
> * CQL {{DROP TYPE}} must check UDFs
> * must check keyspace access permissions (if those exist)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to