[
https://issues.apache.org/jira/browse/CASSANDRA-8452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Blake Eggleston updated CASSANDRA-8452:
---------------------------------------
Attachment: CASSANDRA-8452-v3.patch
Well I'm glad you brought up procfs, since it turns out osx doesn't have one.
The rest of the posix systems we're checking for do [according to wikipedia |
http://en.wikipedia.org/wiki/Procfs]. I guess adding hasProcFS would make some
sense, just for the sake of being correct. At the moment, it only affects
whether some warnings are logged. Basically we eagerly try to open a proc file,
and use isPosix to see if we should log anything if that fails. Relying on
isPosix alone causes erroneous startup warnings in mac dev environments.
I would think isWindows is enough for ntfs specific logic. Linux _can_ mount
and write to ntfs disks, but I'm don't know how common it is for C* to be using
it, outside of maybe some dual boot dev environments. I also not as clear if it
would have the same behaviors we're coding around with isWindows. It's written
against a spec that was reverse engineered from the Windows implementation.
> Add missing systems to FBUtilities.isUnix, add FBUtilities.isWindows
> --------------------------------------------------------------------
>
> Key: CASSANDRA-8452
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8452
> Project: Cassandra
> Issue Type: Bug
> Reporter: Blake Eggleston
> Assignee: Blake Eggleston
> Priority: Minor
> Fix For: 2.1.3
>
> Attachments: CASSANDRA-8452-v2.patch, CASSANDRA-8452-v3.patch,
> CASSANDRA-8452.patch
>
>
> The isUnix method leaves out a few unix systems, which, after the changes in
> CASSANDRA-8136, causes some unexpected behavior during shutdown. It would
> also be clearer if FBUtilities had an isWindows method for branching into
> Windows specific logic.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
