[ https://issues.apache.org/jira/browse/CASSANDRA-8452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Blake Eggleston updated CASSANDRA-8452: --------------------------------------- Attachment: CASSANDRA-8452-v4.patch Ah, I didn't realize that about maybeReopenEarly. In that case, no reason to keep isPosix around. Anyway, I think it's a reasonable convention to assume we're on linux, and check for specific deviations where appropriate, since that's the primary environment we target. Attached v4 > Add missing systems to FBUtilities.isUnix, add FBUtilities.isWindows > -------------------------------------------------------------------- > > Key: CASSANDRA-8452 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8452 > Project: Cassandra > Issue Type: Bug > Reporter: Blake Eggleston > Assignee: Blake Eggleston > Priority: Minor > Fix For: 2.1.3 > > Attachments: CASSANDRA-8452-v2.patch, CASSANDRA-8452-v3.patch, > CASSANDRA-8452-v4.patch, CASSANDRA-8452.patch > > > The isUnix method leaves out a few unix systems, which, after the changes in > CASSANDRA-8136, causes some unexpected behavior during shutdown. It would > also be clearer if FBUtilities had an isWindows method for branching into > Windows specific logic. -- This message was sent by Atlassian JIRA (v6.3.4#6332)