[ https://issues.apache.org/jira/browse/CASSANDRA-8793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333996#comment-14333996 ]
Ariel Weisberg commented on CASSANDRA-8793: ------------------------------------------- +1 on the code that is there. Maybe devil's advocate for what would be a very boring unit test for Memory/MemoryUtil methods that have been added. Could other callers of getKey use the hollow buffer approach in a beneficial way? The iterator in SSTableReader.getKeySamples? > Avoid memory allocation when searching index summary > ---------------------------------------------------- > > Key: CASSANDRA-8793 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8793 > Project: Cassandra > Issue Type: Improvement > Components: Core > Reporter: Benedict > Assignee: Benedict > Priority: Minor > Fix For: 3.0 > > > Currently we build a byte[] for each comparison, when we could just fill the > details into a DirectByteBuffer -- This message was sent by Atlassian JIRA (v6.3.4#6332)