[ 
https://issues.apache.org/jira/browse/CASSANDRA-7660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14351135#comment-14351135
 ] 

Tyler Hobbs commented on CASSANDRA-7660:
----------------------------------------

The attached v2 patch should address your review comments (and I've also 
updated my branch).

bq. I did not see any existing tests covering the serialization/deserialization 
of ResultMessage but I might have missed them. In case we do not have some it 
would be probably good to add some.

I've added some serialization tests for ResultMessage.PreparedMetadata.  I 
agree that it would be good to have serialization tests for the rest of 
ResultMessage, but do you mind if I split that into another ticket (since it's 
pretty large)?

> Indicate PK columns in "prepared" native protocol responses
> -----------------------------------------------------------
>
>                 Key: CASSANDRA-7660
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7660
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Tyler Hobbs
>            Assignee: Tyler Hobbs
>              Labels: protocolv4
>             Fix For: 3.0
>
>         Attachments: 7660-trunk-v2.txt, 7660-trunk.txt
>
>
> Currently, when native protocol drivers prepare statements, they need to 
> check their internal representation of the schema to determine which, if any, 
> of the columns are part of the partition key.  If the native protocol 
> response indicated this, it would remove the drivers' dependency on having an 
> internal representation of the schema when preparing statements.
> This would need to go in the v4 protocol.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to