[ 
https://issues.apache.org/jira/browse/CASSANDRA-8162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14356286#comment-14356286
 ] 

Stefania commented on CASSANDRA-8162:
-------------------------------------

[~iamaleksey], thank you for your review.

I've rebased to 3.0 and added a new column to {{system_trace.sessions}}, please 
check directly https://github.com/stef1927/cassandra/tree/8162.

I could not see the new column in cqlsh until I wiped all the data, is there 
anything else to do when adding a new column to a system table other than 
changing the schema? Also, the client will not appear in the cqlsh automatic 
trace output unless we extend the python driver and cql python library. I did 
not do this.

{{ClientState.remoteAddres}} ultimately comes from the netty channel or java 
socket remote address methods, so at some point we need to downcast to 
{{InetSocketAddress}}. I've placed the downcast in the constructor of 
{{ClientState}}, let me know if this is not what you had in mind.



> Log client address in query trace
> ---------------------------------
>
>                 Key: CASSANDRA-8162
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8162
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Tyler Hobbs
>            Assignee: Stefania
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: 8162.txt
>
>
> With probabilistic tracing, it can be helpful to log the source IP for 
> queries.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to