[
https://issues.apache.org/jira/browse/CASSANDRA-8162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14356378#comment-14356378
]
Aleksey Yeschenko commented on CASSANDRA-8162:
----------------------------------------------
Thanks. That's exactly what I had in mind.
Committed in {{814bd325e55879d93f86c97189893581208556f5}} with some very minor
changes:
- reverted {{ClientState}} constructor changes in favor of moving typecasting
to {{ClientState#forExternalCalls()}} method
- removed the null check/conditional add in
{{TraceKeyspace#makeStartSessionMutation()}} - we don't trace internal calls,
so the address will always be there (and even if it doesn't by some mistake,
{{CFRowAdder#add()}} will just generate a tombstone)
bq. I could not see the new column in cqlsh until I wiped all the data, is
there anything else to do when adding a new column to a system table other than
changing the schema?
For regular system tables (the ones that live inside {{system}} keyspace), no,
there is nothing else to do. {{system_traces.*}} tables, however, are not
handled the same way - we use the default schema propagation algorithm there,
to allow altering the replication factor of tracing. And we do the same for
{{system_auth}}. We should probably not do that - I'll take care of that in a
separate ticket. For now, as you've observed, only fresh 3.0 installs will
observe the new column. But again - I'll deal with it.
bq. Also, the client will not appear in the cqlsh automatic trace output unless
we extend the python driver and cql python library.
Care to open a new ticket and deal with the driver change, or do you want to
delegate to the Drivers team? We do both, depending on the issue.
> Log client address in query trace
> ---------------------------------
>
> Key: CASSANDRA-8162
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8162
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Tyler Hobbs
> Assignee: Stefania
> Priority: Minor
> Fix For: 3.0
>
> Attachments: 8162.txt
>
>
> With probabilistic tracing, it can be helpful to log the source IP for
> queries.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
