[ 
https://issues.apache.org/jira/browse/CASSANDRA-8592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357898#comment-14357898
 ] 

Stefania commented on CASSANDRA-8592:
-------------------------------------

bq. Yes, I'm fine with that (mostly because there's only one caller).

It's done now : 
https://github.com/apache/cassandra/commit/ff527c37bd03f6332d3e787f3b21b4a173c0586e
I still had to convert it in {{MessageDeliveryTask}} because a {{Runnable}} 
cannot throw a checked exception. The alternative would be to absorbe it by 
logging it. On the good side I was wrong about changing the signatures of all 
verb handlers, only {{IVerbHandler}} signature needed changing.

bq. It's not a big deal to fix them in the same patch if they're small changes. 
If they're large, it's nice to split those changes into a separate patch or 
commit to keep the diff clear.

OK, thanks.

> Add WriteFailureException
> -------------------------
>
>                 Key: CASSANDRA-8592
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8592
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: API, Core
>            Reporter: Tyler Hobbs
>            Assignee: Stefania
>              Labels: client-impacting
>             Fix For: 3.0
>
>
> Similar to what CASSANDRA-7886 did for reads, we should add a 
> WriteFailureException and have replicas signal a failure while handling a 
> write to the coordinator.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to