[ 
https://issues.apache.org/jira/browse/CASSANDRA-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969102#action_12969102
 ] 

Jonathan Ellis commented on CASSANDRA-1814:
-------------------------------------------

How confident are you about the UTF8 code?  Do we dare commit for 0.7.0? 0.7.1? 
 Or leave it 0.8 only?

> validation is inefficient
> -------------------------
>
>                 Key: CASSANDRA-1814
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1814
>             Project: Cassandra
>          Issue Type: Improvement
>    Affects Versions: 0.7.0 rc 1
>            Reporter: Gary Dusbabek
>            Assignee: Gary Dusbabek
>         Attachments: v1-0001-type-validations-that-generate-less-garbage.txt
>
>
> We do all validation by simply calling AbstractType.getString().  This 
> generates garbage needlessly and has a lot of overhead.
> A simpler interface would be to make AbstractType.validate abstract and have 
> the child classes implement it in an intelligent and efficient way.
> EDIT: Somewhat related:  It looks like we're attempting to validate column 
> names in ThriftValidation.validateColumns().  Is this intentional?  Nevermind 
> that part. I get it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to