[
https://issues.apache.org/jira/browse/CASSANDRA-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969412#action_12969412
]
Gary Dusbabek commented on CASSANDRA-1814:
------------------------------------------
v2 changes the state machine to use the same logic operations used in
sun.nio.cs.UTF_8. I also added a test that tests all valid UTF8 codepoints to
make sure they validate. I'm pretty confident with it. At the very least, it
will validate invalid utf8, which is impossible to test completely, but it
should not blow up for any valid utf8.
> validation is inefficient
> -------------------------
>
> Key: CASSANDRA-1814
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1814
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 0.7.0 rc 1
> Reporter: Gary Dusbabek
> Assignee: Gary Dusbabek
> Attachments: v1-0001-type-validations-that-generate-less-garbage.txt,
> v2-0001-type-validations-that-generate-less-garbage.txt
>
>
> We do all validation by simply calling AbstractType.getString(). This
> generates garbage needlessly and has a lot of overhead.
> A simpler interface would be to make AbstractType.validate abstract and have
> the child classes implement it in an intelligent and efficient way.
> EDIT: Somewhat related: It looks like we're attempting to validate column
> names in ThriftValidation.validateColumns(). Is this intentional? Nevermind
> that part. I get it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
