[
https://issues.apache.org/jira/browse/CASSANDRA-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14531442#comment-14531442
]
Ariel Weisberg commented on CASSANDRA-8584:
-------------------------------------------
[~JoshuaMcKenzie] If you'll tolerate it I would like to just do both. A
dedicated branch and JIRA for the change to ACS seems excessive.
[~benedict] I updated it to only reset the stat if the log statement fired.
Does that make sense to you or did you mean something more involved when you
mentioned ticket system?
> Add strerror output on failed trySkipCache calls
> ------------------------------------------------
>
> Key: CASSANDRA-8584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8584
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Joshua McKenzie
> Assignee: Ariel Weisberg
> Priority: Trivial
> Fix For: 2.1.x
>
> Attachments: 8584_v1.txt, NoSpamLogger.java, nospamlogger.txt
>
>
> Since trySkipCache returns an errno rather than -1 and setting errno like our
> other CLibrary calls, it's thread-safe and we could print out more helpful
> information if we failed to prompt the kernel to skip the page cache. That
> system call should always succeed unless we have an invalid fd as it's free
> to ignore us.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
