[
https://issues.apache.org/jira/browse/CASSANDRA-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14532335#comment-14532335
]
Benedict commented on CASSANDRA-8584:
-------------------------------------
That looks fine. I have one more suggestion, though (not an important one): It
would _sometimes_ be helpful for the NoSpamLogger to accept a second guard
parameter. For instance, the original goal of this ticket (failed skip cache)
could have different error reasons. It might be helpful to guard them
independently, to avoid suppressing useful information. Not exactly required,
given the non-essential nature of the call, but it could be helpful information
for the operator we're suppressing.
> Add strerror output on failed trySkipCache calls
> ------------------------------------------------
>
> Key: CASSANDRA-8584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8584
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Joshua McKenzie
> Assignee: Ariel Weisberg
> Priority: Trivial
> Fix For: 2.1.x
>
> Attachments: 8584_v1.txt, NoSpamLogger.java, nospamlogger.txt
>
>
> Since trySkipCache returns an errno rather than -1 and setting errno like our
> other CLibrary calls, it's thread-safe and we could print out more helpful
> information if we failed to prompt the kernel to skip the page cache. That
> system call should always succeed unless we have an invalid fd as it's free
> to ignore us.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
