[
https://issues.apache.org/jira/browse/CASSANDRA-8897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14543416#comment-14543416
]
Stefania commented on CASSANDRA-8897:
-------------------------------------
bq. It looks to me like we can simply stop calling channel.sharedCopy() in the
constructor:
What about this:
{code}
public static RandomAccessReader open(File file)
{
try (ChannelProxy channel = new ChannelProxy(file))
{
return open(channel);
}
}
{code}
We've got 16 callers for this method. I was hoping not to have to store a
boolean in the RAR indicating if we should take ownership of the channel or not.
> Remove FileCacheService, instead pooling the buffers
> ----------------------------------------------------
>
> Key: CASSANDRA-8897
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8897
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Benedict
> Assignee: Stefania
> Fix For: 3.x
>
> Attachments: 9240_test_results.txt,
> snapshot-1431582436640-cpu-backtraces.png,
> snapshot-1431582436640-cpu-calltree-compression-8897.nps,
> snapshot-1431582436640-cpu-calltree-compression-trunk.nps
>
>
> After CASSANDRA-8893, a RAR will be a very lightweight object and will not
> need caching, so we can eliminate this cache entirely. Instead we should have
> a pool of buffers that are page-aligned.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
